Hotfix/security monkey v0.7.0 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docker-compose.yml for local development Add secmonkey.env.example for providing a base on how to add environment variables to the containers
SecurityMonkey v0.7.0 Fix build context for NGINX container
configuration changes in config-deploy.py
based on environment values
scriptsrc
reviewed
Nov 3, 2016
|
|
||
| RUN apt-get update &&\ | ||
| apt-get -y -q install python-software-properties software-properties-common postgresql-9.3 postgresql-client-9.3 postgresql-contrib-9.3 curl &&\ | ||
| apt-get install -y python-pip python-dev python-psycopg2 libffi-dev libpq-dev libyaml-dev libxml2-dev libxmlsec1-dev git sudo swig python-m2crypto &&\ |
There was a problem hiding this comment.
PR 188 ( Netflix/security_monkey#188 ) should have removed the requirement for m2crypto.
scriptsrc
reviewed
Nov 3, 2016
| }, | ||
| 'loggers': { | ||
| 'security_monkey': { | ||
| 'handlers': ['file', 'console'], |
There was a problem hiding this comment.
Probably don't want to use file in docker.
Logging should go to stdout, iirc.
scriptsrc
reviewed
Nov 3, 2016
| 'level': 'DEBUG' | ||
| }, | ||
| 'apscheduler': { | ||
| 'handlers': ['file', 'console'], |
There was a problem hiding this comment.
Probably don't want to use file in docker.
Logging should go to stdout, iirc.
|
Looks pretty good. I made a couple comments. (m2crypto probably isn't required anymore and we can probably remove the file handler.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates SecurityMonkey to use the latest (v0.7.0 at this time) release.
Notable changes are: