Refactoring helm for open-telemetry-collector #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NikolaiKuziaevQubership
commented
Jan 24, 2025
NikolaiKuziaevQubership
commented
- The Helm chart has been moved to the charts folder.
- Default values for resources have been added to avoid division-by-zero errors in the HPA manifest when CPU_REQUEST is not specified.
- The Installation-notes have been updated to reflect the latest changes.
- A new variable PAAS_PLATFORM has been added to values.yaml and Installation-notes with a default value for HPA.
- The values.schema.json file has been removed as it is no longer needed.
- Added runAsUser: 10001 to ensure the container runs as a non-root user, as runAsNonRoot: true is enforced.
asatt
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.