Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content Security Policy to webserver configuration #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Content Security Policy to webserver configuration #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda0eb7
Add Content Security Policy to webserver configuration
pablo-knight Aug 25, 2022
308b175
Update privacyidea
pablo-knight Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/apache/sites-available/privacyidea.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
AllowOverride None
</Directory>

# CSP Content-Security-Policy, protect website from click-jacking attacks.
# Allow from self but DENY others
Header set Content-Security-Policy "frame-ancestors 'self';"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do You use frame-ancestors here but default-src in the nginx config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, should be like the apache config "frame-ancestors"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more info:
https://docs.w3cub.com/http/headers/content-security-policy/frame-ancestors
We should additional prevent: 'unsafe-eval' or 'unsafe-inline', frame-ancestors did this as default.

todo:
[ ] test this on a loadbalancer / haproxy


# Yubico servers use /wsapi/2.0/verify as the path in the
# validation URL. Some tools (e.g. Kolab 2fa) let the
# user/admin change the api host, but not the rest of
Expand Down
1 change: 1 addition & 0 deletions deploy/nginx/sites-available/privacyidea
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#}

server {
add_header Content-Security-Policy "frame-ancestors 'self';";
listen 443 ssl;
server_name $hostname;
ssl_certificate /etc/ssl/certs/privacyidea-bundle.crt;
Expand Down