fix nickname not showing

Nerimity · Dec 11, 2024 · c5a3bae · c5a3bae
1 parent 99a7e2a
commit c5a3bae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/components/member-context-menu/MemberContextMenu.tsx b/src/components/member-context-menu/MemberContextMenu.tsx
@@ -84,13 +84,11 @@ export default function MemberContextMenu(props: Props) {
     const clickedOnMyself = props.userId === account.user()?.id;
     const items: any = [];
 
-    const hasAdminPermission = selfMember()?.hasPermission(
-      ROLE_PERMISSIONS.ADMIN
-    );
-    const hasNicknamePermission = selfMember()?.hasPermission(
-      ROLE_PERMISSIONS.NICKNAME_MEMBER
-    );
-    if (hasNicknamePermission && (hasAdminPermission || clickedOnMyself)) {
+    const hasNicknamePermission =
+      selfMember()?.hasPermission(ROLE_PERMISSIONS.NICKNAME_MEMBER) ||
+      clickedOnMyself;
+
+    if (hasNicknamePermission) {
       items.push(nickname);
     }
     const hasManageRolePermission = selfMember()?.hasPermission(
@@ -122,6 +120,7 @@ export default function MemberContextMenu(props: Props) {
 
     const createArr = [];
 
+    hasNicknamePermission && createArr.push(nickname);
     if (hasBanPermission || hasKickPermission) {
       createArr.push(separator);
     }

diff --git a/src/components/ui/context-menu/ContextMenu.tsx b/src/components/ui/context-menu/ContextMenu.tsx
@@ -52,12 +52,16 @@ export default function ContextMenu(props: ContextMenuProps) {
   const [pos, setPos] = createSignal({ top: "0", left: "0" });
   const { isMobileWidth, hasFocus } = useWindowProperties();
 
-  const [items, setItems] = createStore(props.items);
+  const [items, setItems] = createStore<ContextMenuItem[]>([]);
 
   const { height, width } = useResizeObserver(contextMenuEl);
 
   createEffect(() => {
-    setItems(reconcile(props.items));
+    if (props.position) {
+      setItems(reconcile(props.items));
+    } else {
+      setItems([]);
+    }
   });
 
   const handleOutsideClick = (e: any) => {