Detect used Metamask network #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://cherryswap-git-detect-metamask-network.neapolitanswaps.now.sh |
|
@chrisjgf When you have time please check this PR, the modification here help notifying the user to use the correct network to interact with the smart contracts. It only need improvement in the frontend for the alert styling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state, if user use a different network than Kovan,
Cherryswap.deployed()will just throw an exception and the user will not notice what's happening without inspecting the console.This PR fix detect if the network used, if different than Kovan show a message (Related to #13 ).
PS: First time with Vue.js so the code may not be perfect or need improvement! idk 💃