Retain changes to read person list

NatLeong · Apr 9, 2024 · a89e666 · a89e666
1 parent 3e5fde4
commit a89e666
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/main/java/seedu/address/logic/commands/ReadCommand.java b/src/main/java/seedu/address/logic/commands/ReadCommand.java
@@ -1,7 +1,6 @@
 package seedu.address.logic.commands;
 
 import static java.util.Objects.requireNonNull;
-import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;
 
 import seedu.address.commons.util.ToStringBuilder;
 import seedu.address.logic.Messages;
@@ -46,7 +45,6 @@ public CommandResult execute(Model model) throws CommandException {
 
         model.updateFilteredPersonList(new NricContainsKeywordsPredicate(nric.toString()));
         Person readPerson = model.getFilteredPersonList().get(0);
-        model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
 
         return new CommandResult(String.format(MESSAGE_READ_PERSON_SUCCESS, Messages.format(readPerson)));
     }

diff --git a/src/test/java/seedu/address/logic/commands/ReadCommandTest.java b/src/test/java/seedu/address/logic/commands/ReadCommandTest.java
@@ -7,7 +7,6 @@
 import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure;
 import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;
 import static seedu.address.logic.commands.ReadCommand.MESSAGE_READ_PERSON_SUCCESS;
-import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;
 import static seedu.address.testutil.TypicalPersons.ALICE;
 import static seedu.address.testutil.TypicalPersons.getTypicalAddressBook;
 
@@ -18,6 +17,7 @@
 import seedu.address.model.ModelManager;
 import seedu.address.model.UserPrefs;
 import seedu.address.model.person.Nric;
+import seedu.address.model.person.NricContainsKeywordsPredicate;
 
 public class ReadCommandTest {
 
@@ -27,7 +27,7 @@ public class ReadCommandTest {
     void execute_validNric_success() {
         String expectedMessage = String.format(MESSAGE_READ_PERSON_SUCCESS, Messages.format(ALICE));
         ReadCommand command = new ReadCommand(ALICE.getNric());
-        expectedModel.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
+        expectedModel.updateFilteredPersonList(new NricContainsKeywordsPredicate(ALICE.getNric().toString()));
         assertCommandSuccess(command, model, expectedMessage, expectedModel);
     }