Improve subprocess run logging #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddly
reviewed
Oct 29, 2024
puddly
reviewed
Oct 29, 2024
ynezz
pushed a commit
to ynezz/silabs-firmware-builder
that referenced
this pull request
Nov 30, 2024
* Log SLC output. * Update from feedback. * Fix. * Update feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the logs from
slc generateto show up in the Actions logs.I think worth having, especially useful when making changes and
slcdoesn't like it... 😅Note: This is mostly for the "error" scenario, where previously logs wouldn't show up, and only meaningless errors were thrown.