Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid cluster recommendation for Dataproc #1537

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Feb 7, 2025

Fixes #1521.

Currently, AutoTuner/Bootstrapper recommends 1 x n1-standard-16 instance for the input CPU job, which used 8 cores and 2 instances. However, Dataproc does not support clusters with only one worker node.

This PR introduces validateRecommendedCluster, a validation mechanism for recommended cluster configurations. Platform-specific classes can override this method to enforce platform-specific constraints.

Changes

Enhancements to cluster recommendation validation:

Improvements to test coverage:

Test

  • Added an invalid event log and a unit test for dataproc to verify that no cluster is recommended.
  • In future, we could add similar constraints and unit tests for other platforms.

@parthosa parthosa added bug Something isn't working core_tools Scope the core module (scala) labels Feb 7, 2025
@parthosa parthosa self-assigned this Feb 7, 2025
@parthosa parthosa marked this pull request as ready for review February 7, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutoTuner should not recommend jobs with 1 worker nodes in Dataproc
1 participant