-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend G6 instead of G5 on EMR #1523
Conversation
Signed-off-by: sbari <[email protected]>
Signed-off-by: sbari <[email protected]>
c98b31b
to
ce0d774
Compare
Signed-off-by: sbari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sayedbilalbari. Minor comment.
core/src/main/scala/com/nvidia/spark/rapids/tool/Platform.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: sbari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bilalbari. LGTME.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sayedbilalbari for the fix!
Is there any change needed to be done on the Python side?
@parthosa Is there a scenario where the python needs to use the G6 information to build the cluster info if the cluster-property is provided in the CLI argument?
typo in the PR description |
@amahussein I verified if there was a change needed on the python side. My observations and you can correct me if I missed something -
@parthosa Please can you verify. |
@amahussein No changes are required on the Python side. The user provided
That is correct @sayedbilalbari |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sayedbilalbari !
LGTME!
Fixes #1512
Description of the changes -
Changes -