Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/dev' into enable-license-heade…
Browse files Browse the repository at this point in the history
…r-check
  • Loading branch information
YanxuanLiu committed Nov 28, 2024
2 parents 4481806 + bd99422 commit c65a89d
Show file tree
Hide file tree
Showing 35 changed files with 2,993 additions and 164 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/premerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ concurrency:
cancel-in-progress: true

jobs:
build docker image:
build-docker-image:
runs-on: ubuntu-20.04
steps:
- name: Checkout
Expand Down
18 changes: 8 additions & 10 deletions .github/workflows/signoff-check.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2022, NVIDIA CORPORATION.
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -23,12 +23,10 @@ jobs:
signoff-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: sigoff-check job
uses: ./.github/workflows/signoff-check
env:
OWNER: NVIDIA
REPO_NAME: spark-rapids-container
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PULL_NUMBER: ${{ github.event.number }}
- name: signoff
uses: NVIDIA/spark-rapids-common/signoff-check@main
with:
owner: ${{ github.repository_owner }}
repo: spark-rapids-container
pull_number: ${{ github.event.number }}
token: ${{ secrets.GITHUB_TOKEN }}
22 changes: 0 additions & 22 deletions .github/workflows/signoff-check/Dockerfile

This file was deleted.

19 changes: 0 additions & 19 deletions .github/workflows/signoff-check/action.yml

This file was deleted.

71 changes: 0 additions & 71 deletions .github/workflows/signoff-check/signoff-check

This file was deleted.

6 changes: 2 additions & 4 deletions Databricks/00-custom-spark-driver-defaults.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2022, NVIDIA CORPORATION.
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -14,8 +14,6 @@
[driver] {
"spark.plugins" = "com.nvidia.spark.SQLPlugin"
"spark.rapids.memory.pinnedPool.size" = "2G"
"spark.databricks.delta.optimizeWrite.enabled" = "false"
"spark.sql.optimizer.dynamicPartitionPruning.enabled" = "false"
"spark.sql.files.maxPartitionBytes" = "512m"
"spark.rapids.sql.concurrentGpuTasks" = "2"
}
}
66 changes: 66 additions & 0 deletions Databricks/Alluxio-2.9.0-without-CVE/build-from-src-and-fix-CVE.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
#!/bin/bash
# Copyright (c) 2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

#############################################
# This script is used to compile, patch Alluxio code and install Alluxio to fix the Alluxio CVE issues.
# Waiting Alluxio to fix all the Alluxio CVE issues will be a long-term work.
# So we fix CVE issues by workaround method: build Alluxio ourselves, exclude and upgrade some 3PP jars.
#############################################

set -e

# clone Alluxio code, apply patches and compile
cd /tmp/Alluxio-2.9.0-without-CVE
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
git clone https://github.com/Alluxio/alluxio.git
cd alluxio/
git checkout v2.9.0 -b v2.9.0-fix-cve
git am /tmp/Alluxio-2.9.0-without-CVE/patches/*
# update `libexec/alluxio-config.sh`, replace the client and server jar as the Alluxio building script does.
# For details, refer to:
# https://github.com/Alluxio/alluxio/blob/v2.9.0/dev/scripts/src/alluxio.org/build-distribution/cmd/generate-tarball.go#L274-L275
git am /tmp/Alluxio-2.9.0-without-CVE/update-assembly-jar-path.patch

echo "Compiling Alluxio, this may take some time ..."
mvn clean install -q -Pufs-hadoop-3 -Dufs.hadoop.version=3.2.4 -Dmaven.javadoc.skip=true -Dmaven.test.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dhadoop.version=3.2.4 -T 4
echo "Compile done"

# setup Alluxio program located in `/opt` path
# This section is copying only specific jars so we can avoid CVE issues in the unused jars
cd ../
mkdir alluxio-2.9.0
cp -r ./alluxio/bin ./alluxio-2.9.0
mkdir ./alluxio-2.9.0/assembly
cp ./alluxio/assembly/server/target/alluxio-assembly-server-2.9.0-jar-with-dependencies.jar ./alluxio-2.9.0/assembly/alluxio-server-2.9.0.jar
cp ./alluxio/assembly/client/target/alluxio-assembly-client-2.9.0-jar-with-dependencies.jar ./alluxio-2.9.0/assembly/alluxio-client-2.9.0.jar
mkdir ./alluxio-2.9.0/client
cp ./alluxio/client/alluxio-2.9.0-client.jar ./alluxio-2.9.0/client
cp -r ./alluxio/conf/ ./alluxio-2.9.0/conf
cp ./log4j2-master.properties ./log4j2-worker.properties ./alluxio-2.9.0/conf
mkdir ./alluxio-2.9.0/lib
# Skip coping other /lib/alluxio-underfs-xxx.jar except the underfs-local and underfs-s3a 2 jars
cp ./alluxio/lib/alluxio-underfs-local-2.9.0.jar ./alluxio-2.9.0/lib
cp ./alluxio/lib/alluxio-underfs-s3a-2.9.0.jar ./alluxio-2.9.0/lib
cp -r ./alluxio/libexec ./alluxio-2.9.0

cp ./alluxio/LICENSE ./alluxio-2.9.0/LICENSE
mkdir ./alluxio-2.9.0/webui
cp -r ./alluxio/webui/master ./alluxio-2.9.0/webui
cp -r ./alluxio/webui/worker ./alluxio-2.9.0/webui
mkdir ./alluxio-2.9.0/logs
mv alluxio-2.9.0 /opt
rm -rf /tmp/Alluxio-2.9.0-without-CVE
rm -rf ~/.m2
38 changes: 38 additions & 0 deletions Databricks/Alluxio-2.9.0-without-CVE/log4j2-master.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#
# Copyright (c) 2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# log level of log4j itself
status=warn

# rolling appender
appender.rolling.type=RollingFile
appender.rolling.name=fileAppender
appender.rolling.filter.threshold.type=ThresholdFilter
appender.rolling.filter.threshold.level=info
appender.rolling.layout.type=PatternLayout
appender.rolling.layout.pattern=%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{1}: %m%n
appender.rolling.append=true
appender.rolling.fileName=/opt/alluxio-2.9.0/logs/master.log
appender.rolling.policies.type=Policies
appender.rolling.policies.size.type=SizeBasedTriggeringPolicy
appender.rolling.policies.size.size=10MB
appender.rolling.strategy.type=DefaultRolloverStrategy
appender.rolling.strategy.max=100
appender.rolling.filePattern=/opt/alluxio-2.9.0/logs/master.log.%d{yyyyMMdd}-%i.log.gz

rootLogger.level=info
rootLogger.appenderRef.rolling.ref=fileAppender

38 changes: 38 additions & 0 deletions Databricks/Alluxio-2.9.0-without-CVE/log4j2-worker.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#
# Copyright (c) 2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# log level of log4j itself
status=warn

# rolling appender
appender.rolling.type=RollingFile
appender.rolling.name=fileAppender
appender.rolling.filter.threshold.type=ThresholdFilter
appender.rolling.filter.threshold.level=info
appender.rolling.layout.type=PatternLayout
appender.rolling.layout.pattern=%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{1}: %m%n
appender.rolling.append=true
appender.rolling.fileName=/opt/alluxio-2.9.0/logs/worker.log
appender.rolling.policies.type=Policies
appender.rolling.policies.size.type=SizeBasedTriggeringPolicy
appender.rolling.policies.size.size=10MB
appender.rolling.strategy.type=DefaultRolloverStrategy
appender.rolling.strategy.max=100
appender.rolling.filePattern=/opt/alluxio-2.9.0/logs/worker.log.%d{yyyyMMdd}-%i.log.gz

rootLogger.level=info
rootLogger.appenderRef.rolling.ref=fileAppender

Loading

0 comments on commit c65a89d

Please sign in to comment.