Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverting adapt cpu logic to use GPU as default #372

Merged
merged 2 commits into from
Jan 23, 2025
Merged

reverting adapt cpu logic to use GPU as default #372

merged 2 commits into from
Jan 23, 2025

Conversation

jperez999
Copy link
Collaborator

@jperez999 jperez999 commented Jan 23, 2025 •
edited
Loading

Description

this PR reverts the logic that allows for indexing on GPU and search on CPU. Current settings degrade recall drastically.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jperez999 jperez999 added the bug Something isn't working label Jan 23, 2025
@jperez999 jperez999 self-assigned this Jan 23, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

ChrisJar
ChrisJar approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@ChrisJar ChrisJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@jperez999 jperez999 merged commit 684335e into NVIDIA:main Jan 23, 2025
3 checks passed
jdye64 pushed a commit to jdye64/nv-ingest that referenced this pull request Jan 24, 2025
@jperez999 @jdye64
reverting adapt cpu logic to use GPU as default (NVIDIA#372)
06d244b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

@ChrisJar ChrisJar ChrisJar approved these changes

@randerzander randerzander Awaiting requested review from randerzander

@jdye64 jdye64 Awaiting requested review from jdye64

@edknv edknv Awaiting requested review from edknv

Assignees

@jperez999 jperez999

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jperez999 @drobison00 @ChrisJar