-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new MultiNodeEnvironment CRD to setup the environment needed for running GPU workloads across multi-nodes #225
Open
klueska
wants to merge
32
commits into
NVIDIA:main
Choose a base branch
from
klueska:add-multi-node-crd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klueska
force-pushed
the
add-multi-node-crd
branch
10 times, most recently
from
January 14, 2025 08:15
38065b4
to
3e51cd8
Compare
klueska
force-pushed
the
add-multi-node-crd
branch
20 times, most recently
from
January 22, 2025 15:56
4ce9bdb
to
0d435d8
Compare
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
For now they are just clones of each other, but subsequent commits will fine tune them to either the GPU driver or the IMEX driver. Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
github.com/elezar/nvidia-container-toolkit/tree/add-imex-binaries Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
from
January 25, 2025 23:06
c8b9975
to
0a96b95
Compare
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
This is in prepration for calling RemoveFinalizer on all components in one standardized location. Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
2 times, most recently
from
January 27, 2025 23:48
800d905
to
e598f17
Compare
We no longer need this code now that we have a finalizer on the ComputeDomain object itself that only gets removed if all other linked objects have been removed. Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
from
January 28, 2025 12:46
e598f17
to
89e085f
Compare
For now we are conditioning it on the hardcoded value of 'true', but in the future we want to condition it on the absenece of workloads running in the compute domain neing deleted. Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
from
January 28, 2025 12:58
89e085f
to
bf742a7
Compare
Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
from
January 28, 2025 17:13
76f751a
to
970fb95
Compare
Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
add-multi-node-crd
branch
from
January 28, 2025 17:18
970fb95
to
3b7a65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.