Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-relnote] Add CodeQL code scanning #891

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[no-relnote] Add CodeQL code scanning #891

merged 1 commit into from
Aug 20, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez self-assigned this Aug 9, 2024
@ArangoGutierrez ArangoGutierrez requested a review from elezar August 9, 2024 15:25
@ArangoGutierrez ArangoGutierrez force-pushed the codeql branch 2 times, most recently from 7f765e5 to 8c38f59 Compare August 9, 2024 15:36
@elezar elezar changed the title [no-relnote] Add CodeQL conde scanning [no-relnote] Add CodeQL code scanning Aug 12, 2024
@ArangoGutierrez
Copy link
Collaborator Author

Commit message has also been updated to fix the typo

@elezar
Copy link
Member

elezar commented Aug 12, 2024

Question: Does this annotate the code in the PR or do we need to check the Security tab?

@ArangoGutierrez
Copy link
Collaborator Author

Question: Does this annotate the code in the PR or do we need to check the Security tab?

https://docs.github.com/en/code-security/code-scanning/managing-code-scanning-alerts/triaging-code-scanning-alerts-in-pull-requests#code-scanning-results-check

@ArangoGutierrez ArangoGutierrez requested a review from elezar August 12, 2024 11:30
@ArangoGutierrez ArangoGutierrez force-pushed the codeql branch 2 times, most recently from 64cb65e to 0c4ccfd Compare August 12, 2024 13:52
@ArangoGutierrez
Copy link
Collaborator Author

Ready for review, all requested changes have been addressed

@ArangoGutierrez ArangoGutierrez force-pushed the codeql branch 2 times, most recently from fbfd9e9 to 68a973f Compare August 18, 2024 15:43
@ArangoGutierrez
[no-relnote] Add CodeQL code scanning
1817036 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez mentioned this pull request Aug 18, 2024
Merged
@ArangoGutierrez ArangoGutierrez merged commit 248ab88 into NVIDIA:main Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArangoGutierrez @elezar