Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow qvector arguments for custom operations #2454

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya commented Dec 5, 2024

Fix for issue #2452.
In a follow up, we will look into supporting some of the scenarios that currently raise an error. As is right now, they would not be properly executed, so we give an error until this is properly supported.

@khalatepradnya khalatepradnya self-assigned this Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@khalatepradnya khalatepradnya marked this pull request as ready for review December 6, 2024 00:02
@khalatepradnya khalatepradnya changed the title [bug-fix] Custom operations - qvector arguments [bug-fix] Custom operations - disallow qvector arguments Dec 6, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@khalatepradnya khalatepradnya enabled auto-merge (squash) December 10, 2024 20:49
@khalatepradnya khalatepradnya enabled auto-merge (squash) December 10, 2024 20:49
@khalatepradnya khalatepradnya enabled auto-merge (squash) December 11, 2024 05:46
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@khalatepradnya khalatepradnya merged commit 72eab56 into NVIDIA:main Dec 11, 2024
211 checks passed
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Dec 11, 2024
@bettinaheim bettinaheim changed the title [bug-fix] Custom operations - disallow qvector arguments Disallow qvector arguments for custom operations Dec 11, 2024
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@bettinaheim bettinaheim added this to the release 0.9.1 milestone Dec 11, 2024
@khalatepradnya khalatepradnya deleted the fix-issue-2452 branch December 11, 2024 15:58
bettinaheim pushed a commit that referenced this pull request Dec 11, 2024
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix To be listed under Bug Fixes in the release notes no release notes Don't list this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants