Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back transformer engine install #658

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jan 24, 2025

Adds back the custom transformer engine install to avoid the import error on python debugging. https://nvidia.slack.com/archives/C074Z808N05/p1737753519355939

@pstjohn pstjohn marked this pull request as ready for review January 24, 2025 23:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (60a6dad) to head (abfb04a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         118      118           
  Lines        7059     7059           
=======================================
  Hits         6124     6124           
  Misses        935      935           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pstjohn pstjohn enabled auto-merge January 25, 2025 15:06
Dockerfile Outdated Show resolved Hide resolved
@pstjohn pstjohn marked this pull request as draft January 28, 2025 21:57
auto-merge was automatically disabled January 28, 2025 21:57

Pull request was converted to draft

Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
@pstjohn pstjohn marked this pull request as ready for review January 29, 2025 00:20
@pstjohn pstjohn enabled auto-merge January 29, 2025 00:21
@pstjohn pstjohn added this pull request to the merge queue Jan 29, 2025
Merged via the queue into NVIDIA:main with commit 691e210 Jan 29, 2025
7 checks passed
@pstjohn pstjohn deleted the pstjohn/reinstall-te branch January 29, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants