Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds helper API to create pool #1877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds helper API to create pool #1877

wants to merge 1 commit into from

Conversation

syed-ahmed
Copy link
Contributor

@syed-ahmed syed-ahmed commented Jan 21, 2025 •
edited
Loading

Without the changes in this PR, only one mempool in device 0 gets created in a distributed launch, instead of a mempool per rank.

Aidyn-A
Aidyn-A approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Aidyn-A Aidyn-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one mempool in device 0 gets created in a distributed launch

Just for potential improvement in future: Is there a safe way of creating the mempool implicitly, so users will not need to manually create one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aidyn-A Aidyn-A Aidyn-A approved these changes

@eqy eqy eqy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syed-ahmed @eqy @Aidyn-A