Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX] Test_multiprocessing_encoder with process spawn in bash #1394

Merged
merged 5 commits into from
Jan 11, 2025

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Jan 8, 2025

Description

Using the multithreading module which uses os.fork() with JAX which is already multithreading can lead to deadlocks and is not recommended.
This PR removed the usage of multithreading, but spawning processes in a bash script helper.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Infra/Build change
  • Code refactor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng phu0ngng requested a review from zlsh80826 January 8, 2025 16:08
@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Jan 8, 2025

/te-ci jax

@phu0ngng phu0ngng merged commit a65ad37 into NVIDIA:main Jan 11, 2025
14 checks passed
@phu0ngng phu0ngng deleted the jax/test/multiprocess_encoder branch January 11, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants