-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context_logits for eval accuracy calculation in case of multi token prediction tasks #11753
base: main
Are you sure you want to change the base?
Conversation
630966e
to
5fb26b1
Compare
4bd6b47
to
8cbaef3
Compare
cd4e7e6
to
900ad07
Compare
def _generate_tokens_logits( | ||
self, payload, single_prediction_token, return_text: bool = False, return_logits: bool = False | ||
): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Uses bool generation_logits_available as inputs dict does not contain it Signed-off-by: Abhishree <[email protected]>
Signed-off-by: Abhishree <[email protected]>
Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Signed-off-by: Abhishree <[email protected]>
Signed-off-by: Abhishree <[email protected]>
07925a5
to
f0c3cb3
Compare
for more information, see https://pre-commit.ci
Signed-off-by: athitten <[email protected]>
for more information, see https://pre-commit.ci
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified:
Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you please run the examples here https://docs.nvidia.com/nemo-framework/user-guide/latest/deployment/llm/optimized/tensorrt_llm.html and make sure nothing is broken?
What does this PR do ?
This PR adds the following changes:
Uses
context_logits
to computelogProbs
in case of eval benchmarks that have multiple token prediction. For ex:arc_challenge
,arc_easy
,winogrande
,copa
etc., (where asMMLU
,lambada
are single token prediction benchmarks. Usesgeneration_logits
for these benchmarks to avoid large payload fromcontext_logits
)In order to get
context_logits
for evals, the PR exposesgather_context_logits
andoutput_context
logits inexport
anddeploy
files similar to previously existedgeneration_logits
Introduces
requirements_eval.txt
file to installlm-eval-harness
in NeMo FW containers.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information