Add DGXCloud executor based on Run.ai REST API #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return None | ||
| executor.delete(job_id) | ||
|
|
||
| def list(self) -> list[ListAppResponse]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Signed-off-by: Hemil Desai <[email protected]>
| "Logs not available for DGXCloudExecutor based jobs. Please visit the cluster UI to view the logs." | ||
| ) | ||
|
|
||
| def cleanup(self, handle: str): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
pablo-garay
previously approved these changes
Feb 4, 2025
DGX Cloud uses the PyTorch Training Operator from KubeFlow under the hood to launch jobs. This handles many of the variables necessary for running distributed PyTorch jobs with torchrun and only a subset of settings are required to launch the job as the original default settings will conflict with the auto-configured setup from DGX Cloud. Signed-Off-By: Robert Clark <[email protected]>
Add support for torchrun to DGXC Executor
Signed-off-by: Pablo Garay <[email protected]>
pablo-garay
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.