Minor updates to duplicate removal #570
Conversation
Signed-off-by: Sarah Yurick <[email protected]>
| if not duplicates_to_remove: | ||
| return None | ||
| warnings.warn("No fuzzy duplicates to remove, returning original dataset") | ||
| return dataset |
There was a problem hiding this comment.
The main thing I wanted to change with this PR is to return the original dataset when there are no duplicates, instead of returning None.
There was a problem hiding this comment.
I also prefer removing the Dataset, but I think @ayushdg might have some thoughts
#326 (comment)
There was a problem hiding this comment.
I think this comment is a bit different than the change I am making here. This does not return an empty dataset, it returns the original dataset (AKA a dataset with no duplicates removed).
There was a problem hiding this comment.
So it sounds like identify will still retain the behavior of returning None but remove might default to returning the original dataset.
There was a problem hiding this comment.
Yes that is correct.
Signed-off-by: Sarah Yurick <[email protected]>
Fixes a few nits from #509.