Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PyTests for Nemotron-CC classifiers #543

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Enable PyTests for Nemotron-CC classifiers #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cace5cb
Enable PyTests for Nemotron-CC classifiers
sarahyurick Feb 12, 2025
571350c
Update copyright year
sarahyurick Feb 13, 2025
b142465
Merge branch 'main' into nemotron-cc-pytests
sarahyurick Feb 14, 2025
0191cba
revert pyproject toml change
sarahyurick Feb 14, 2025
bd5629a
Merge branch 'main' into nemotron-cc-pytests
sarahyurick Feb 18, 2025
0d19bf5
push
sarahyurick Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_curator/scripts/classifiers/fineweb_mixtral_edu_classifier_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion nemo_curator/scripts/classifiers/fineweb_nemotron_edu_classifier_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
8 changes: 1 addition & 7 deletions tests/test_classifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -139,9 +139,6 @@ def test_fineweb_edu_classifier(gpu_client, domain_dataset):
assert result_pred.equals(expected_pred)


@pytest.mark.skip(
reason="Skipping until https://huggingface.co/nvidia/nemocurator-fineweb-mixtral-edu-classifier is published"
)
@pytest.mark.gpu
def test_fineweb_mixtral_classifier(gpu_client, domain_dataset):
from nemo_curator.classifiers import FineWebMixtralEduClassifier
Expand All @@ -155,9 +152,6 @@ def test_fineweb_mixtral_classifier(gpu_client, domain_dataset):
assert result_pred.equals(expected_pred)


@pytest.mark.skip(
reason="Skipping until https://huggingface.co/nvidia/nemocurator-fineweb-nemotron-4-edu-classifier is published"
)
@pytest.mark.gpu
def test_fineweb_nemotron_classifier(gpu_client, domain_dataset):
from nemo_curator.classifiers import FineWebNemotronEduClassifier
Expand Down