Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU CI tests by creating 1 cluster across sessions #540

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

VibhuJawa
Copy link
Collaborator

Description

This PR provides an alternate to #539 by providing a session-scoped gpu_client fixture to manage the lifecycle of the GPU client and cluster.

Creating cluster is often a slow process, so i think this should also speedup our CI slightly.

Related github issue: dask/distributed#3540

Signed-off-by: Vibhu Jawa <[email protected]>
@VibhuJawa VibhuJawa added the gpuci Run GPU CI/CD on PR label Feb 11, 2025
@VibhuJawa VibhuJawa added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Feb 11, 2025
@VibhuJawa VibhuJawa changed the title Fix GPU CI tests Fix GPU CI tests by creating 1 cluster across sessions Feb 11, 2025
Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuci Run GPU CI/CD on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants