-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook to show Fineweb ensemble #536
Conversation
Signed-off-by: Vibhu Jawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround!
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few small comments.
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
tutorials/distributed_data_classification/fineweb-edu-ensebmle-classification.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the FastText class!
tutorials/distributed_data_classification/fineweb-edu-ensemble-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensemble-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensemble-classification.ipynb
Outdated
Show resolved
Hide resolved
tutorials/distributed_data_classification/fineweb-edu-ensemble-classification.ipynb
Outdated
Show resolved
Hide resolved
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
Should be good to update once #543 can be merged, thanks. |
Signed-off-by: Vibhu Jawa <[email protected]>
CC: @sarahyurick , @ryantwolf , Please take a final look, have updated with the newly released classifiers. Thanks again @sarahyurick for all the work you have done to get it across the finish line at such a tight deadline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a lingering TODO.
tutorials/distributed_data_classification/fineweb-edu-ensemble-classification.ipynb
Outdated
Show resolved
Hide resolved
…-classification.ipynb Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Description
This PR adds a notebook provides an end-to-end workflow for ensembling multiple edu classifiers, including:
I am currently just show casing this using existing EDU classifier multiple times, but we will change that once #518 lands