Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook to show Fineweb ensemble #536

Merged
merged 16 commits into from
Feb 14, 2025

Conversation

VibhuJawa
Copy link
Collaborator

Description

This PR adds a notebook provides an end-to-end workflow for ensembling multiple edu classifiers, including:

  • FineWeb Mixtral Educational Classifier
  • FineWeb Nemotron-4 Educational Classifier
  • FastText OH-ELI5 (Hugging Face)

I am currently just show casing this using existing EDU classifier multiple times, but we will change that once #518 lands

@VibhuJawa VibhuJawa marked this pull request as ready for review February 10, 2025 22:48
Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

VibhuJawa and others added 4 commits February 10, 2025 15:02
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small comments.

Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the FastText class!

VibhuJawa and others added 4 commits February 12, 2025 13:50
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
@sarahyurick
Copy link
Collaborator

Should be good to update once #543 can be merged, thanks.

@VibhuJawa
Copy link
Collaborator Author

CC: @sarahyurick , @ryantwolf , Please take a final look, have updated with the newly released classifiers.

Thanks again @sarahyurick for all the work you have done to get it across the finish line at such a tight deadline.

Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a lingering TODO.

…-classification.ipynb

Co-authored-by: Sarah Yurick <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
@VibhuJawa
Copy link
Collaborator Author

Looks like there's a lingering TODO.

Done

Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@VibhuJawa VibhuJawa merged commit 0f0cb31 into NVIDIA:main Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants