Pin Transformers version >= 4.48.0 #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <[email protected]>
VibhuJawa
reviewed
Feb 7, 2025
pyproject.toml
Outdated
| @@ -66,8 +66,7 @@ dependencies = [ | |||
| "resiliparse", | |||
| "sentencepiece", | |||
| "spacy>=3.6.0, <3.8.0", | |||
| # TODO: Remove this pin once newer version is released | |||
| "transformers==4.46.3", | |||
| "transformers", | |||
There was a problem hiding this comment.
Should we pin to say not include broken version ?
Suggested change
| "transformers", | |
| "transformers!=4.47.0", |
There was a problem hiding this comment.
Good point, although I think it was fixed by 4.48.0 so I might try transformers>=4.48.0.
There was a problem hiding this comment.
I will also check if the upper bound works with Nvidia's NeMo container. If it works, then a upper pin is great, If it does not a more permissive pin (which just prevents 1 version) might be the way to go.
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
added
gpuci
ryantwolf
approved these changes
Feb 11, 2025
sarahyurick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.