Fix DAPT tutorial #503
Merged
Fix DAPT tutorial #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
commented
Jan 30, 2025
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
added
gpuci
VibhuJawa
requested changes
Jan 31, 2025
tutorials/dapt-curation/README.md
Outdated
| python main.py | ||
| # or python main.py --device "gpu" |
There was a problem hiding this comment.
Is it an or here , should this by the default ?
Signed-off-by: Sarah Yurick <[email protected]>
|
Looks like the failures are caused by flaky |
ruchaa-apte
reviewed
Jan 31, 2025
| @@ -37,11 +37,8 @@ | |||
| ) | |||
|
|
|||
| import nemo_curator as nc | |||
| from nemo_curator import ExactDuplicates, Modify, ScoreFilter, Sequential | |||
There was a problem hiding this comment.
Hey @sarahyurick - Is it possible to revert these sections that are deleted from the DAPT tutorial?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantic deduplication portion of the DAPT tutorial is currently failing with a
ValueError("'category' column dtypes are currently not supported by the gpu accelerated parquet writer"). A quick way to avoid this error is to avoid writing the embeddings to disk.