Make add_filename str/bool
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
sarahyurick
reviewed
Jan 3, 2025
| @@ -273,6 +273,18 @@ def _set_torch_to_use_rmm(): | |||
| torch.cuda.memory.change_current_allocator(rmm_torch_allocator) | |||
|
|
|||
|
|
|||
| def _resolve_filename_col(filename: Union[bool, str]) -> Union[str, bool]: | |||
There was a problem hiding this comment.
I like this a lot, thanks! Was wondering if other files from #449 (like doc_dataset.py) need to be updated as well?
There was a problem hiding this comment.
Oops looks like I forgot all the APIs where those changes needed to be made. Added those too now thanks!
There was a problem hiding this comment.
I still think you could be missing some?
- https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/download/doc_builder.py
- https://github.com/NVIDIA/NeMo-Curator/blob/main/docs/user-guide/documentdataset.rst
- https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/utils/file_utils.py
And writing logic such as in https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/utils/distributed_utils.py.
Signed-off-by: Praateek <[email protected]>
…n/NeMo-Curator into praateek/filename-col-str
praateekmahajan
added
gpuci
sarahyurick
requested changes
Jan 6, 2025
| @@ -273,6 +273,18 @@ def _set_torch_to_use_rmm(): | |||
| torch.cuda.memory.change_current_allocator(rmm_torch_allocator) | |||
|
|
|||
|
|
|||
| def _resolve_filename_col(filename: Union[bool, str]) -> Union[str, bool]: | |||
There was a problem hiding this comment.
I still think you could be missing some?
- https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/download/doc_builder.py
- https://github.com/NVIDIA/NeMo-Curator/blob/main/docs/user-guide/documentdataset.rst
- https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/utils/file_utils.py
And writing logic such as in https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/utils/distributed_utils.py.
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
praateekmahajan
added
gpuci
Signed-off-by: Praateek <[email protected]>
praateekmahajan
added
gpuci
Signed-off-by: Praateek <[email protected]>
praateekmahajan
added
gpuci
sarahyurick
reviewed
Jan 7, 2025
| @@ -824,24 +837,26 @@ def _merge_tmp_simple_bitext_partitions(tmp_output_dir: str, output_dir: str): | |||
| def write_to_disk( | |||
| df, | |||
| output_path: str, | |||
| write_to_filename: bool = False, | |||
| write_to_filename: Union[bool, str] = False, | |||
Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Praateek Mahajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired from
dask.read_jsonwhereinclude_path_column : bool or str, optional:We also had a bug in our code where we were doing
include_path_column=Trueand then renaming the column frompath -> file_name. This meant if there was already apathcolumn we would have an error.Usage
# Add snippet demonstrating usageChecklist