-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.5.0 forward merge #340
V0.5.0 forward merge #340
Conversation
Signed-off-by: Ryan Wolf <[email protected]>
* pin to 24.8 Signed-off-by: Praateek Mahajan <[email protected]> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * unrestrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Praateek Mahajan <[email protected]>
* Change download for NSFW model Signed-off-by: Ryan Wolf <[email protected]> * Fix model init Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Not sure if the DCO errors are applicable here or not. Seems to be some weird mismatch in expected email addresses from an old commit. I'm tempted to set DCO to pass unless someone has suggestions. |
I think that is fine, but if you want to, you can always rebase and fix commit message for that commit with that email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm fine setting the DCO to pass. Do you know which commit in particular is causing problems?
Commit sha: 1dddfed, Author: Praateek Mahajan, Committer: GitHub; Can not find "Praateek Mahajan [email protected]", in ["Praateek Mahajan [email protected]", "Praateek Mahajan [email protected]", "Praateek Mahajan [email protected]", "Praateek Mahajan [email protected]", "Praateek Mahajan [email protected]", "Praateek Mahajan [email protected]"]. It's a commit that's already in the other branch untouched by the merge. |
hold off one second until Tanay gets his fix in. |
Signed-off-by: Tanay Varshney <[email protected]>
…orward_merge Signed-off-by: Ayush Dattagupta <[email protected]>
@ayushdg I think we're good now, any reservations on merging? |
Nope. I also think I understand the source of the DCO confusion. When merging in a PR, GitHub UI asks for an email address to associate with the merge commit into the branch. If that email address doesn't typically match the email addresses used by a developer for signing off commits, DCO gets a bit thrown off, because we now have a squash & merge commit from a different email address than the one used to sign off commits in the git history. |
* Bump version Signed-off-by: Ryan Wolf <[email protected]> * Pin Rapids to 24.8 for 0.5.0 Release (NVIDIA#273) * pin to 24.8 Signed-off-by: Praateek Mahajan <[email protected]> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * unrestrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]> * Fix tutorial for release (NVIDIA#277) Signed-off-by: Ryan Wolf <[email protected]> * Fix nworkers for tinystories tutorial (NVIDIA#280) Signed-off-by: Ryan Wolf <[email protected]> * Pin to 24.8.x instead of 24.8 (NVIDIA#282) Signed-off-by: Praateek Mahajan <[email protected]> * Change NSFW Model (NVIDIA#307) * Change download for NSFW model Signed-off-by: Ryan Wolf <[email protected]> * Fix model init Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> * Bump version to 0.6.0.dev0 Signed-off-by: Ayush Dattagupta <[email protected]> * added error handling (NVIDIA#343) Signed-off-by: Tanay Varshney <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Praateek Mahajan <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]> Signed-off-by: Tanay Varshney <[email protected]> Co-authored-by: Ryan Wolf <[email protected]> Co-authored-by: Praateek Mahajan <[email protected]> Co-authored-by: Tanay Varshney <[email protected]> Signed-off-by: Vinay Raman <[email protected]>
* Bump version Signed-off-by: Ryan Wolf <[email protected]> * Pin Rapids to 24.8 for 0.5.0 Release (NVIDIA#273) * pin to 24.8 Signed-off-by: Praateek Mahajan <[email protected]> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * unrestrict spacy Signed-off-by: Praateek Mahajan <[email protected]> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]> * Fix tutorial for release (NVIDIA#277) Signed-off-by: Ryan Wolf <[email protected]> * Fix nworkers for tinystories tutorial (NVIDIA#280) Signed-off-by: Ryan Wolf <[email protected]> * Pin to 24.8.x instead of 24.8 (NVIDIA#282) Signed-off-by: Praateek Mahajan <[email protected]> * Change NSFW Model (NVIDIA#307) * Change download for NSFW model Signed-off-by: Ryan Wolf <[email protected]> * Fix model init Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> * Bump version to 0.6.0.dev0 Signed-off-by: Ayush Dattagupta <[email protected]> * added error handling (NVIDIA#343) Signed-off-by: Tanay Varshney <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Praateek Mahajan <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]> Signed-off-by: Tanay Varshney <[email protected]> Co-authored-by: Ryan Wolf <[email protected]> Co-authored-by: Praateek Mahajan <[email protected]> Co-authored-by: Tanay Varshney <[email protected]> Signed-off-by: Rucha Apte <[email protected]>
Description
Merge in changes from the 0.5.0 release into main.
Specifically excludes the changes around our requirements.txt being pinned to specific versions in the previous release.
Also bumps our current version to 0.6.0.dev0 for folks installing from source.
Usage
N/A
Checklist