-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style check #3
Conversation
Looks like the |
There's no reason for them to match exactly, some of it depends on the practices we want to follow for the repo so it's good to go over the differences:
|
Ok cool. Thanks for the clarification.
|
Actually I stand corrected, other repos do use this but specify the config in their pyproject.toml file. I'll probably do the same. |
This also has the side effect of pre-commit.ci auto formatting all the files. @ryantwolf Are you okay updating all the file formats in this PR? |
It had to happen at some point haha. Let's reformat the code 🫡 |
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
…line length Signed-off-by: Ayush Dattagupta <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Ayush Dattagupta <[email protected]>
Co-authored-by: Ryan Wolf <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
This PR adds a short README.md file for the TinyStories tutorial, with instructions on how to run it. Signed-off-by: Mehran Maghoumi <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]>
* Add workflow for cpu pytests Signed-off-by: Ayush Dattagupta <[email protected]> * Install wheel to fix fasttext import Signed-off-by: Ayush Dattagupta <[email protected]> * Omit python 3.8, do not fast fail Signed-off-by: Ayush Dattagupta <[email protected]> * Check if updating setuptools/pip changes cython errors Signed-off-by: Ayush Dattagupta <[email protected]> * Explicitly install cython Signed-off-by: Ayush Dattagupta <[email protected]> * Try freeing up space before install Signed-off-by: Ayush Dattagupta <[email protected]> * Try rapids_no_initialize Signed-off-by: Ayush Dattagupta <[email protected]> * remove python 3.9 testing for now Signed-off-by: Ayush Dattagupta <[email protected]> --------- Signed-off-by: Ayush Dattagupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me. Just fix the DCO error by using the --signoff
option on your commits.
a8980a5
to
f607633
Compare
Had some weirdness during the rebasing with signoff. Will open a new PR |
The aim of the PR is to add pre-commit configs and a GHA for style checks.
The PR does not attempt to fix all the style failures present in the repo. That will be done in a followup PR.
The config ends up using
isort, black & flake8
(some of it included in the contributing guide).Happy to also explore ruff which should be a much faster drop in replacement for some of the tools mentioned above and has been adopted by many large python projects.