Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id field #250

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix id field #250

merged 1 commit into from
Sep 17, 2024

Conversation

ryantwolf
Copy link
Collaborator

@ryantwolf ryantwolf commented Sep 17, 2024

Description

Fixes the id field bug in the lsh script. Tested and verified the fix works.

Usage

N/A

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ryan Wolf <[email protected]>
Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryantwolf ryantwolf merged commit 5c6ccb4 into main Sep 17, 2024
3 checks passed
@ryantwolf ryantwolf deleted the rywolf/lsh-fix branch September 17, 2024 17:40
VibhuJawa pushed a commit to VibhuJawa/NeMo-Curator that referenced this pull request Oct 1, 2024
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 9, 2024
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Yang Yu <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 10, 2024
vinay-raman pushed a commit to vinay-raman/NeMo-Curator that referenced this pull request Nov 12, 2024
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Vinay Raman <[email protected]>
vinay-raman pushed a commit to vinay-raman/NeMo-Curator that referenced this pull request Nov 13, 2024
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Vinay Raman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants