Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tutorials] Update tutorial documentations #241

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[Tutorials] Update tutorial documentations #241

merged 1 commit into from
Sep 11, 2024

Conversation

Maghoumi
Copy link
Collaborator

@Maghoumi Maghoumi commented Sep 10, 2024 •
edited
Loading

Description

  • Add a README file for the tutorials.
  • Add a table of all tutorials, along with a brief description of each one.
  • Add a structure outline to the README file of the SDG tutorial to make it more accessible.
  • Add a block diagram to the SDG tutorial further clarify the pipeline.

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@Maghoumi Maghoumi force-pushed the mmaghoumi/update-sdg-readme branch 4 times, most recently from c90c617 to ede062a Compare September 10, 2024 22:47
@Maghoumi Maghoumi requested a review from ryantwolf September 10, 2024 23:06
@Maghoumi Maghoumi force-pushed the mmaghoumi/update-sdg-readme branch 4 times, most recently from c061067 to 9ef8dd0 Compare September 11, 2024 19:10
@Maghoumi
[Tutorials] Update tutorial documentations
8e00df5 
- Add a README file for the tutorials.
- Add a table of all tutorials, along with a brief description of each
one.
- Add a structure outline to the README file of the SDG tutorial to make it more accessible.
- Add a block diagram to the SDG tutorial further clarify the pipeline.

Signed-off-by: Mehran Maghoumi <[email protected]>
@Maghoumi Maghoumi force-pushed the mmaghoumi/update-sdg-readme branch from 9ef8dd0 to 8e00df5 Compare September 11, 2024 19:14
@Maghoumi Maghoumi changed the title [Tutorials] Update the SDG tutorial's documentation [Tutorials] Update tutorial documentations Sep 11, 2024
ryantwolf
ryantwolf approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Thank you!

@ryantwolf ryantwolf merged commit adc68a1 into NVIDIA:main Sep 11, 2024
3 checks passed
VibhuJawa pushed a commit to VibhuJawa/NeMo-Curator that referenced this pull request Oct 1, 2024
@Maghoumi @VibhuJawa
[Tutorials] Update tutorial documentations (NVIDIA#241)
d607e26 
- Add a README file for the tutorials.
- Add a table of all tutorials, along with a brief description of each
one.
- Add a structure outline to the README file of the SDG tutorial to make it more accessible.
- Add a block diagram to the SDG tutorial further clarify the pipeline.

Signed-off-by: Mehran Maghoumi <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 9, 2024
@Maghoumi @yyu22
[Tutorials] Update tutorial documentations (NVIDIA#241)
ffa135b 
- Add a README file for the tutorials.
- Add a table of all tutorials, along with a brief description of each
one.
- Add a structure outline to the README file of the SDG tutorial to make it more accessible.
- Add a block diagram to the SDG tutorial further clarify the pipeline.

Signed-off-by: Mehran Maghoumi <[email protected]>
Signed-off-by: Yang Yu <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 10, 2024
@Maghoumi @yyu22
[Tutorials] Update tutorial documentations (NVIDIA#241)
7f07a62 
- Add a README file for the tutorials.
- Add a table of all tutorials, along with a brief description of each
one.
- Add a structure outline to the README file of the SDG tutorial to make it more accessible.
- Add a block diagram to the SDG tutorial further clarify the pipeline.

Signed-off-by: Mehran Maghoumi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantwolf ryantwolf ryantwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maghoumi @ryantwolf