-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image documentation #238
Conversation
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
The docs are ready to review. |
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial! Added general comments and proofreading.
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
@sarahyurick I addressed most of your feedback. I left comments where I disagreed / wanted clarification. Please take another look when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! I believe there should just be 3 more comments from my previous review that still need to be updated, otherwise LGTM.
Signed-off-by: Ryan Wolf <[email protected]>
I think I addressed all your concerns @sarahyurick, let me know if I missed anything though. |
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ryan Wolf <[email protected]>
* Add partial image implementation Signed-off-by: Ryan Wolf <[email protected]> * Refactor requirements Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs Signed-off-by: Ryan Wolf <[email protected]> * Change from_map to map_partitions Signed-off-by: Ryan Wolf <[email protected]> * Add super constructor Signed-off-by: Ryan Wolf <[email protected]> * Add kwargs for load_object_on_worker Signed-off-by: Ryan Wolf <[email protected]> * Get proper epoch size Signed-off-by: Ryan Wolf <[email protected]> * Complete embedding creation loop Signed-off-by: Ryan Wolf <[email protected]> * Change devices Signed-off-by: Ryan Wolf <[email protected]> * Add device Signed-off-by: Ryan Wolf <[email protected]> * Refactor embedding creation and add classifier Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs in classifiers Signed-off-by: Ryan Wolf <[email protected]> * Refactor model names Signed-off-by: Ryan Wolf <[email protected]> * Add model name Signed-off-by: Ryan Wolf <[email protected]> * Fix classifier bugs Signed-off-by: Ryan Wolf <[email protected]> * Allow postprocessing for classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix name and add print Signed-off-by: Ryan Wolf <[email protected]> * Fix variable name Signed-off-by: Ryan Wolf <[email protected]> * Add NSFW Signed-off-by: Ryan Wolf <[email protected]> * Update init for import Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> * Add fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix missing index Signed-off-by: Ryan Wolf <[email protected]> * Update metdata for fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Add export to webdataset Signed-off-by: Ryan Wolf <[email protected]> * Fix missing id col Signed-off-by: Ryan Wolf <[email protected]> * Sort embeddings by id Signed-off-by: Ryan Wolf <[email protected]> * Add timm Signed-off-by: Ryan Wolf <[email protected]> * Update init file Signed-off-by: Ryan Wolf <[email protected]> * Add autocast to timm Signed-off-by: Ryan Wolf <[email protected]> * Update requirements and transform Signed-off-by: Ryan Wolf <[email protected]> * Add additional interpolation support Signed-off-by: Ryan Wolf <[email protected]> * Fix transform normalization Signed-off-by: Ryan Wolf <[email protected]> * Remove open_clip Signed-off-by: Ryan Wolf <[email protected]> * Add index path support to wds Signed-off-by: Ryan Wolf <[email protected]> * Address Vibhu's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add import guard for image dataset Signed-off-by: Ryan Wolf <[email protected]> * Change default device Signed-off-by: Ryan Wolf <[email protected]> * Remove commented code Signed-off-by: Ryan Wolf <[email protected]> * Remove device id Signed-off-by: Ryan Wolf <[email protected]> * Fix index issue Signed-off-by: Ryan Wolf <[email protected]> * Add docstrings and standardize variable names Signed-off-by: Ryan Wolf <[email protected]> * Add image curation tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add initial image docs Signed-off-by: Ryan Wolf <[email protected]> * Remove tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add dataset docs Signed-off-by: Ryan Wolf <[email protected]> * Add embedder documentation Signed-off-by: Ryan Wolf <[email protected]> * Revert embedding column name change Signed-off-by: Ryan Wolf <[email protected]> * Update user guide for images Signed-off-by: Ryan Wolf <[email protected]> * Update README Signed-off-by: Ryan Wolf <[email protected]> * Update README with RAPIDS nightly instructions Signed-off-by: Ryan Wolf <[email protected]> * Fix formatting issues in image documentation Signed-off-by: Ryan Wolf <[email protected]> * Remove extra newline in README Signed-off-by: Ryan Wolf <[email protected]> * Address most of Sarah's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add section summary Signed-off-by: Ryan Wolf <[email protected]> * Fix errors and REWORD GPU bullets in README Signed-off-by: Ryan Wolf <[email protected]> * Fix how table of contents displays with new sections Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]>
* Add partial image implementation Signed-off-by: Ryan Wolf <[email protected]> * Refactor requirements Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs Signed-off-by: Ryan Wolf <[email protected]> * Change from_map to map_partitions Signed-off-by: Ryan Wolf <[email protected]> * Add super constructor Signed-off-by: Ryan Wolf <[email protected]> * Add kwargs for load_object_on_worker Signed-off-by: Ryan Wolf <[email protected]> * Get proper epoch size Signed-off-by: Ryan Wolf <[email protected]> * Complete embedding creation loop Signed-off-by: Ryan Wolf <[email protected]> * Change devices Signed-off-by: Ryan Wolf <[email protected]> * Add device Signed-off-by: Ryan Wolf <[email protected]> * Refactor embedding creation and add classifier Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs in classifiers Signed-off-by: Ryan Wolf <[email protected]> * Refactor model names Signed-off-by: Ryan Wolf <[email protected]> * Add model name Signed-off-by: Ryan Wolf <[email protected]> * Fix classifier bugs Signed-off-by: Ryan Wolf <[email protected]> * Allow postprocessing for classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix name and add print Signed-off-by: Ryan Wolf <[email protected]> * Fix variable name Signed-off-by: Ryan Wolf <[email protected]> * Add NSFW Signed-off-by: Ryan Wolf <[email protected]> * Update init for import Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> * Add fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix missing index Signed-off-by: Ryan Wolf <[email protected]> * Update metdata for fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Add export to webdataset Signed-off-by: Ryan Wolf <[email protected]> * Fix missing id col Signed-off-by: Ryan Wolf <[email protected]> * Sort embeddings by id Signed-off-by: Ryan Wolf <[email protected]> * Add timm Signed-off-by: Ryan Wolf <[email protected]> * Update init file Signed-off-by: Ryan Wolf <[email protected]> * Add autocast to timm Signed-off-by: Ryan Wolf <[email protected]> * Update requirements and transform Signed-off-by: Ryan Wolf <[email protected]> * Add additional interpolation support Signed-off-by: Ryan Wolf <[email protected]> * Fix transform normalization Signed-off-by: Ryan Wolf <[email protected]> * Remove open_clip Signed-off-by: Ryan Wolf <[email protected]> * Add index path support to wds Signed-off-by: Ryan Wolf <[email protected]> * Address Vibhu's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add import guard for image dataset Signed-off-by: Ryan Wolf <[email protected]> * Change default device Signed-off-by: Ryan Wolf <[email protected]> * Remove commented code Signed-off-by: Ryan Wolf <[email protected]> * Remove device id Signed-off-by: Ryan Wolf <[email protected]> * Fix index issue Signed-off-by: Ryan Wolf <[email protected]> * Add docstrings and standardize variable names Signed-off-by: Ryan Wolf <[email protected]> * Add image curation tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add initial image docs Signed-off-by: Ryan Wolf <[email protected]> * Remove tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add dataset docs Signed-off-by: Ryan Wolf <[email protected]> * Add embedder documentation Signed-off-by: Ryan Wolf <[email protected]> * Revert embedding column name change Signed-off-by: Ryan Wolf <[email protected]> * Update user guide for images Signed-off-by: Ryan Wolf <[email protected]> * Update README Signed-off-by: Ryan Wolf <[email protected]> * Update README with RAPIDS nightly instructions Signed-off-by: Ryan Wolf <[email protected]> * Fix formatting issues in image documentation Signed-off-by: Ryan Wolf <[email protected]> * Remove extra newline in README Signed-off-by: Ryan Wolf <[email protected]> * Address most of Sarah's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add section summary Signed-off-by: Ryan Wolf <[email protected]> * Fix errors and REWORD GPU bullets in README Signed-off-by: Ryan Wolf <[email protected]> * Fix how table of contents displays with new sections Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Ayush Dattagupta <[email protected]>
* Add partial image implementation Signed-off-by: Ryan Wolf <[email protected]> * Refactor requirements Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs Signed-off-by: Ryan Wolf <[email protected]> * Change from_map to map_partitions Signed-off-by: Ryan Wolf <[email protected]> * Add super constructor Signed-off-by: Ryan Wolf <[email protected]> * Add kwargs for load_object_on_worker Signed-off-by: Ryan Wolf <[email protected]> * Get proper epoch size Signed-off-by: Ryan Wolf <[email protected]> * Complete embedding creation loop Signed-off-by: Ryan Wolf <[email protected]> * Change devices Signed-off-by: Ryan Wolf <[email protected]> * Add device Signed-off-by: Ryan Wolf <[email protected]> * Refactor embedding creation and add classifier Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs in classifiers Signed-off-by: Ryan Wolf <[email protected]> * Refactor model names Signed-off-by: Ryan Wolf <[email protected]> * Add model name Signed-off-by: Ryan Wolf <[email protected]> * Fix classifier bugs Signed-off-by: Ryan Wolf <[email protected]> * Allow postprocessing for classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix name and add print Signed-off-by: Ryan Wolf <[email protected]> * Fix variable name Signed-off-by: Ryan Wolf <[email protected]> * Add NSFW Signed-off-by: Ryan Wolf <[email protected]> * Update init for import Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> * Add fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix missing index Signed-off-by: Ryan Wolf <[email protected]> * Update metdata for fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Add export to webdataset Signed-off-by: Ryan Wolf <[email protected]> * Fix missing id col Signed-off-by: Ryan Wolf <[email protected]> * Sort embeddings by id Signed-off-by: Ryan Wolf <[email protected]> * Add timm Signed-off-by: Ryan Wolf <[email protected]> * Update init file Signed-off-by: Ryan Wolf <[email protected]> * Add autocast to timm Signed-off-by: Ryan Wolf <[email protected]> * Update requirements and transform Signed-off-by: Ryan Wolf <[email protected]> * Add additional interpolation support Signed-off-by: Ryan Wolf <[email protected]> * Fix transform normalization Signed-off-by: Ryan Wolf <[email protected]> * Remove open_clip Signed-off-by: Ryan Wolf <[email protected]> * Add index path support to wds Signed-off-by: Ryan Wolf <[email protected]> * Address Vibhu's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add import guard for image dataset Signed-off-by: Ryan Wolf <[email protected]> * Change default device Signed-off-by: Ryan Wolf <[email protected]> * Remove commented code Signed-off-by: Ryan Wolf <[email protected]> * Remove device id Signed-off-by: Ryan Wolf <[email protected]> * Fix index issue Signed-off-by: Ryan Wolf <[email protected]> * Add docstrings and standardize variable names Signed-off-by: Ryan Wolf <[email protected]> * Add image curation tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add initial image docs Signed-off-by: Ryan Wolf <[email protected]> * Remove tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add dataset docs Signed-off-by: Ryan Wolf <[email protected]> * Add embedder documentation Signed-off-by: Ryan Wolf <[email protected]> * Revert embedding column name change Signed-off-by: Ryan Wolf <[email protected]> * Update user guide for images Signed-off-by: Ryan Wolf <[email protected]> * Update README Signed-off-by: Ryan Wolf <[email protected]> * Update README with RAPIDS nightly instructions Signed-off-by: Ryan Wolf <[email protected]> * Fix formatting issues in image documentation Signed-off-by: Ryan Wolf <[email protected]> * Remove extra newline in README Signed-off-by: Ryan Wolf <[email protected]> * Address most of Sarah's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add section summary Signed-off-by: Ryan Wolf <[email protected]> * Fix errors and REWORD GPU bullets in README Signed-off-by: Ryan Wolf <[email protected]> * Fix how table of contents displays with new sections Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Vinay Raman <[email protected]>
* Add partial image implementation Signed-off-by: Ryan Wolf <[email protected]> * Refactor requirements Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs Signed-off-by: Ryan Wolf <[email protected]> * Change from_map to map_partitions Signed-off-by: Ryan Wolf <[email protected]> * Add super constructor Signed-off-by: Ryan Wolf <[email protected]> * Add kwargs for load_object_on_worker Signed-off-by: Ryan Wolf <[email protected]> * Get proper epoch size Signed-off-by: Ryan Wolf <[email protected]> * Complete embedding creation loop Signed-off-by: Ryan Wolf <[email protected]> * Change devices Signed-off-by: Ryan Wolf <[email protected]> * Add device Signed-off-by: Ryan Wolf <[email protected]> * Refactor embedding creation and add classifier Signed-off-by: Ryan Wolf <[email protected]> * Fix bugs in classifiers Signed-off-by: Ryan Wolf <[email protected]> * Refactor model names Signed-off-by: Ryan Wolf <[email protected]> * Add model name Signed-off-by: Ryan Wolf <[email protected]> * Fix classifier bugs Signed-off-by: Ryan Wolf <[email protected]> * Allow postprocessing for classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix name and add print Signed-off-by: Ryan Wolf <[email protected]> * Fix variable name Signed-off-by: Ryan Wolf <[email protected]> * Add NSFW Signed-off-by: Ryan Wolf <[email protected]> * Update init for import Signed-off-by: Ryan Wolf <[email protected]> * Fix embedding size Signed-off-by: Ryan Wolf <[email protected]> * Add fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Fix missing index Signed-off-by: Ryan Wolf <[email protected]> * Update metdata for fused classifiers Signed-off-by: Ryan Wolf <[email protected]> * Add export to webdataset Signed-off-by: Ryan Wolf <[email protected]> * Fix missing id col Signed-off-by: Ryan Wolf <[email protected]> * Sort embeddings by id Signed-off-by: Ryan Wolf <[email protected]> * Add timm Signed-off-by: Ryan Wolf <[email protected]> * Update init file Signed-off-by: Ryan Wolf <[email protected]> * Add autocast to timm Signed-off-by: Ryan Wolf <[email protected]> * Update requirements and transform Signed-off-by: Ryan Wolf <[email protected]> * Add additional interpolation support Signed-off-by: Ryan Wolf <[email protected]> * Fix transform normalization Signed-off-by: Ryan Wolf <[email protected]> * Remove open_clip Signed-off-by: Ryan Wolf <[email protected]> * Add index path support to wds Signed-off-by: Ryan Wolf <[email protected]> * Address Vibhu's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add import guard for image dataset Signed-off-by: Ryan Wolf <[email protected]> * Change default device Signed-off-by: Ryan Wolf <[email protected]> * Remove commented code Signed-off-by: Ryan Wolf <[email protected]> * Remove device id Signed-off-by: Ryan Wolf <[email protected]> * Fix index issue Signed-off-by: Ryan Wolf <[email protected]> * Add docstrings and standardize variable names Signed-off-by: Ryan Wolf <[email protected]> * Add image curation tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add initial image docs Signed-off-by: Ryan Wolf <[email protected]> * Remove tutorial Signed-off-by: Ryan Wolf <[email protected]> * Add dataset docs Signed-off-by: Ryan Wolf <[email protected]> * Add embedder documentation Signed-off-by: Ryan Wolf <[email protected]> * Revert embedding column name change Signed-off-by: Ryan Wolf <[email protected]> * Update user guide for images Signed-off-by: Ryan Wolf <[email protected]> * Update README Signed-off-by: Ryan Wolf <[email protected]> * Update README with RAPIDS nightly instructions Signed-off-by: Ryan Wolf <[email protected]> * Fix formatting issues in image documentation Signed-off-by: Ryan Wolf <[email protected]> * Remove extra newline in README Signed-off-by: Ryan Wolf <[email protected]> * Address most of Sarah's feedback Signed-off-by: Ryan Wolf <[email protected]> * Add section summary Signed-off-by: Ryan Wolf <[email protected]> * Fix errors and REWORD GPU bullets in README Signed-off-by: Ryan Wolf <[email protected]> * Fix how table of contents displays with new sections Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Rucha Apte <[email protected]>
Description
This PR adds
Usage
N/A
Checklist