Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SemDedup docs #232

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update SemDedup docs #232

merged 2 commits into from
Sep 16, 2024

Conversation

sarahyurick
Copy link
Collaborator

Closes #203

@sarahyurick
edit docs
853c681 
Signed-off-by: Sarah Yurick <[email protected]>
ryantwolf
ryantwolf requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for touching this up. There's one thing to change but other than that looks good.

@sarahyurick
fix bullet pts
4732abc 
Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick
Copy link
Collaborator Author

Hi @ryantwolf this is ready for review again.

ryantwolf
ryantwolf approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ryantwolf ryantwolf merged commit 8d9ba84 into NVIDIA:main Sep 16, 2024
3 checks passed
VibhuJawa pushed a commit to VibhuJawa/NeMo-Curator that referenced this pull request Oct 1, 2024
@sarahyurick @VibhuJawa
Update SemDedup docs (NVIDIA#232)
3afa53c 
* edit docs

Signed-off-by: Sarah Yurick <[email protected]>

* fix bullet pts

Signed-off-by: Sarah Yurick <[email protected]>

---------

Signed-off-by: Sarah Yurick <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 9, 2024
@sarahyurick @yyu22
Update SemDedup docs (NVIDIA#232)
5ac1b02 
* edit docs

Signed-off-by: Sarah Yurick <[email protected]>

* fix bullet pts

Signed-off-by: Sarah Yurick <[email protected]>

---------

Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Yang Yu <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 10, 2024
@sarahyurick @yyu22
Update SemDedup docs (NVIDIA#232)
6da67c6 
* edit docs

Signed-off-by: Sarah Yurick <[email protected]>

* fix bullet pts

Signed-off-by: Sarah Yurick <[email protected]>

---------

Signed-off-by: Sarah Yurick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantwolf ryantwolf ryantwolf approved these changes

Assignees

@sarahyurick sarahyurick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SemDeDup README
2 participants
@sarahyurick @ryantwolf