Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content for experiment tracking for DLI #3203

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Add content for experiment tracking for DLI #3203

merged 9 commits into from
Feb 10, 2025

Conversation

nvkevlu
Copy link
Collaborator

@nvkevlu nvkevlu commented Feb 5, 2025

Add content for experiment tracking for DLI.

Description

Add content for experiment tracking for DLI.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvkevlu nvkevlu enabled auto-merge (squash) February 6, 2025 21:36
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Feb 6, 2025

/build

@nvkevlu nvkevlu requested a review from ZiyueXu77 February 7, 2025 03:30
chesterxgchen
chesterxgchen previously requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely missing the introduction section on experiment tracking

@nvkevlu nvkevlu requested a review from chesterxgchen February 7, 2025 16:57
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Feb 7, 2025

/build

@nvkevlu nvkevlu dismissed chesterxgchen’s stale review February 10, 2025 15:53

introduction has been added

@ZiyueXu77
Copy link
Collaborator

/build

@nvkevlu nvkevlu merged commit b40e8a1 into NVIDIA:main Feb 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvkevlu @ZiyueXu77 @chesterxgchen