Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Cherry pick xgb updates #3099

Merged
merged 6 commits into from
Dec 10, 2024
Merged

[2.5] Cherry pick xgb updates #3099

merged 6 commits into from
Dec 10, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Dec 10, 2024 •
edited
Loading

Description

Cherry-pick #2970 #3039 #3044 #3046 #3078 #3085

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

ZiyueXu77 and others added 6 commits December 10, 2024 14:47
@ZiyueXu77 @chesterxgchen @YuanTingHsieh
Add GNN encoder and xgb outputs for finance end-to-end example (NVIDI…
232823b 
…A#2970)

* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

---------

Co-authored-by: Chester Chen <[email protected]>
@ZiyueXu77 @chesterxgchen @YuanTingHsieh
Update the GNN encoding for XGB financial example (NVIDIA#3039)
bc46189 
* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

* update the GNN embedding usage

---------

Co-authored-by: Chester Chen <[email protected]>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
@ZiyueXu77 @YuanTingHsieh
Add XGB explainability output (NVIDIA#3044)
aa77116 
* Add XGB explainability output

* typo fix

* format fix
@ZiyueXu77 @YuanTingHsieh
Update finance end-to-end readme for figure position (NVIDIA#3046)
5296aff 
* Update README.md

* Update xgboost.ipynb
@YuanTingHsieh
Fix xgb explanability issue (NVIDIA#3078)
a7dd73d
@YuanTingHsieh
Implement a new algorithm for the CUDA plugin (NVIDIA#3085)
5cc658a 
* New cuda plugin implementation

Signed-off-by: YuanTingHsieh <[email protected]>

* Update docstring

* Rename CellTable to GHPairArray for clarity and allow max_num_of_gh_pair_per_launch to be customized

---------

Signed-off-by: YuanTingHsieh <[email protected]>
@YuanTingHsieh YuanTingHsieh changed the title Cherry pick xgb updates [2.5] Cherry pick xgb updates Dec 10, 2024
nvidianz
nvidianz approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvidianz
Copy link
Collaborator

/build

@nvidianz nvidianz mentioned this pull request Dec 10, 2024
Closed
6 tasks
ZiyueXu77
ZiyueXu77 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YuanTingHsieh YuanTingHsieh merged commit f0378ac into NVIDIA:2.5 Dec 10, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the cherry_pick_xgb_updates branch December 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

@nvidianz nvidianz nvidianz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @nvidianz @ZiyueXu77