-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job launcher server side #3055
Job launcher server side #3055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. I like the refactoring of the launchers so server and client launchers could be written more easily.
The get_job_launcher() function needs to be improved to be fl-ctx safe and thread safe. See my comments there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes for the use of the new fl ctx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build |
/build |
Fixes # .
Description
Added the server side job launcher API support. Also added the ServerK8sJobLauncher for K8s kubernete.
Types of changes
./runtest.sh
.