Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job launcher server side #3055

Merged
merged 50 commits into from
Nov 15, 2024
Merged

Job launcher server side #3055

merged 50 commits into from
Nov 15, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Nov 1, 2024

Fixes # .

Description

Added the server side job launcher API support. Also added the ServerK8sJobLauncher for K8s kubernete.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yhwen yhwen marked this pull request as draft November 1, 2024 14:26
@yhwen yhwen marked this pull request as ready for review November 1, 2024 19:10
@yhwen yhwen changed the title Job launcher server side --- Need wait Client side PR 3049 to merge first Job launcher server side Nov 1, 2024
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I like the refactoring of the launchers so server and client launchers could be written more easily.

The get_job_launcher() function needs to be improved to be fl-ctx safe and thread safe. See my comments there.

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for the use of the new fl ctx.

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwen
Copy link
Collaborator Author

yhwen commented Nov 15, 2024

/build

@yhwen yhwen enabled auto-merge (squash) November 15, 2024 16:18
@yhwen
Copy link
Collaborator Author

yhwen commented Nov 15, 2024

/build

@yhwen yhwen merged commit c25c914 into NVIDIA:main Nov 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants