Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Fix hello-pt req [skip ci] #3036

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[2.5] Fix hello-pt req [skip ci] #3036

merged 1 commit into from
Oct 14, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Fix requirement

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh requested a review from nvkevlu October 14, 2024 17:13
nvkevlu
nvkevlu approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@nvkevlu nvkevlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@nvkevlu
Copy link
Collaborator

nvkevlu commented Oct 14, 2024

/build

@nvkevlu nvkevlu enabled auto-merge (squash) October 14, 2024 17:48
@nvkevlu nvkevlu merged commit fa098b2 into NVIDIA:2.5 Oct 14, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_pt_req_25 branch October 14, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkevlu nvkevlu nvkevlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @nvkevlu