Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Fedbpt fix #3030

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[2.5] Fedbpt fix #3030

merged 2 commits into from
Oct 10, 2024
+4 −3

Conversation

holgerroth
Copy link
Collaborator

Fixes # .

Description

Cherry-pick #3029

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth
FedBPT: Fix fedbpt cma version (NVIDIA#3029)
51789fb 
* fix cma version; upgrade nvflare version

* upgrade python to 3.12
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) October 10, 2024 21:26
@YuanTingHsieh
Copy link
Collaborator

/build

YuanTingHsieh
YuanTingHsieh approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth holgerroth merged commit 737d2ea into NVIDIA:2.5 Oct 10, 2024
20 checks passed
@holgerroth holgerroth deleted the fedbpt_fix_2.5 branch October 11, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerroth @YuanTingHsieh