Skip to content

Commit

Permalink
Fix project master templates (#2617)
Browse files Browse the repository at this point in the history
The `project.yml` generated by `nvflare provision` command has
comments `change overseer.example.com to the FQDN of the overseer`
and `change example.com to the FQDN of the server` but the actual
values nowhere has `example.com` mentioned and it is confusing.

This change just fixes comments to make it more clear.

Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
  • Loading branch information
apatole and YuanTingHsieh authored Jun 12, 2024
1 parent 857a6e2 commit 67dc2c5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
4 changes: 3 additions & 1 deletion nvflare/lighter/dummy_project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ name: example_project
description: NVIDIA FLARE sample project yaml file

participants:
# change example.com to the FQDN of the server
# Change the name of the server (server1) to the Fully Qualified Domain Name
# (FQDN) of the server, for example: server1.example.com.
# Ensure that the FQDN is correctly mapped in the /etc/hosts file.
- name: server1
type: server
org: nvidia
Expand Down
11 changes: 9 additions & 2 deletions nvflare/lighter/ha_project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,26 @@ name: example_project
description: NVIDIA FLARE sample project yaml file

participants:
# change overseer.example.com to the FQDN of the overseer
# Change the name of the overseer to the Fully Qualified Domain Name (FQDN)
# of the overseer, for example: overseer.example.com.
# Ensure that the FQDN is correctly mapped in the /etc/hosts file.
- name: overseer
type: overseer
org: nvidia
protocol: https
api_root: /api/v1
port: 8443
# change example.com to the FQDN of the server
# Change the name of the server (server1) to the Fully Qualified Domain Name
# (FQDN) of the first server, for example: server1.example.com.
# Ensure that the FQDN is correctly mapped in the /etc/hosts file.
- name: server1
type: server
org: nvidia
fed_learn_port: 8002
admin_port: 8003
# Change the name of the server (server2) to the Fully Qualified Domain Name
# (FQDN) of the second server, for example: server2.example.com.
# Ensure that the FQDN is correctly mapped in the /etc/hosts file.
- name: server2
type: server
org: nvidia
Expand Down

0 comments on commit 67dc2c5

Please sign in to comment.