First version of MATX sparse2dense conversion (dispatch to cuSPARSE) #856
+446
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aartbik
changed the title
|
/build |
cliffburdick
reviewed
Feb 4, 2025
| template <typename OpA> | ||
| class Sparse2DenseOp : public BaseOp<Sparse2DenseOp<OpA>> { | ||
| private: | ||
| typename detail::base_type_t<OpA> a_; |
There was a problem hiding this comment.
Make sure base_type is updated to recognize sparse if that's what you want. this will convert a sparse tensor to a tensor_impl_t
There was a problem hiding this comment.
Sorry, can you elaborate on this a bit, please?
cliffburdick
reviewed
Feb 4, 2025
cliffburdick
reviewed
Feb 4, 2025
cliffburdick
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.