-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant cast in a test #3852
base: main
Are you sure you want to change the base?
Conversation
Review updated until commit b909282 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
!build |
tests/cpp/test_persistent_buffer.cpp
Outdated
fusion.addInput(input); | ||
fusion.addInput(weight); | ||
fusion.addInput(bias); | ||
if (dtype == DataType::Half) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a maybeCastOp that may save you some typing.
Co-authored-by: Jingyue Wu <[email protected]>
!build |
!build |
!test |
I was wondering why there is an additional no op scheduler when the input data is
float32
. It turns out due to the redundant cast, we only need the cast when the input isfloat16
.This PR removes that cast for fp32.