-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove multiReductionInliner #3851
base: main
Are you sure you want to change the base?
Conversation
Review updated until commit 6065332 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
cached_inputs, | ||
cached_outputs); | ||
unroll_vectorizable_cached_tvs); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reduction scheduler, no need to call sharedMemoryConsumerVectorization
and Remove dummy outputs
since these two functions are for persistent buffers.
!test |
What?
Code clean up, removes
multiReductionInliner()
why?
This function was used in reduction scheduler and inner persistent scheduler, however, the usage are different and it takes many paras to differentiate the different usages.
This PR removes
multiReductionInliner()
and adds inlined function calls in reduction scheduler and inner persistent scheduler, separately. This change makes further extension of inner persistent scheudler to use TMA easier.