[WIP] Enable resize scheduler by default

[naoyam]

No description provided.

[naoyam]

!test

[github-actions]

Review updated until commit c79e234

Description

• Enable resize scheduler by default

• Update option handling for resize scheduler

• Modify logic in preseg_passes and scheduler

• Adjust tests to reflect new default

---

Changes walkthrough 📝

	Relevant files
Configuration changes	3 files options.cpp Move resize scheduler option to disable options                    +1/-1      options.h Move resize scheduler option to disable options                    +1/-1      loop_domain_scheduler.h Update cancelReshapeInLoopDomains signature                            +6/-1
Enhancement	4 files pre_segmenter.cpp Update resize scheduler check                                                        +1/-1      resize.cpp Update resize scheduler logic                                                        +8/-6      loop_domain_scheduler.cpp Enhance cancelReshapeInLoopDomains with skip_innermost_id +25/-4    resize_utils.cpp Update scheduleLoopDomainsBy call                                                +2/-1
Tests	3 files test_move_pad.cpp Disable resize scheduler in MovePadTest                                    +7/-1      test_resize.cpp Update tests to disable resize scheduler                                  +6/-18    test_rope.cpp Update RopeTest to use ResizeTest                                                +1/-9

---

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests

⚡ Recommended focus areas for review Default Behavior The PR enables the resize scheduler by default, but it seems that the scheduler is still being disabled in several test cases. Ensure that the default behavior is correctly implemented and that tests are updated to reflect this change. if (isOptionDisabled(DisableOption::ResizeScheduler)) { scheduler_debug_utils::canScheduleRejectReason(schedulerType(), "Disabled"); return false; } Innermost ID Handling The cancelReshapeInLoopDomains function now includes a skip_innermost_id parameter. Ensure that this change does not introduce any unintended behavior and that the logic is correctly implemented. } // Update the loop domain by each of the reshape exprs in a // reverse topological order. auto reshape_exprs = DependencyCheck::getAllExprsBetween( {reshape_out->getRootDomain().begin(), reshape_out->getRootDomain().end()}, {reshape_out->getLogicalDomain().begin(), reshape_out->getLogicalDomain().end()}); std::unordered_set<Expr*> reshape_exprs_with_innermost_logical_id_set; if (skip_innermost_id) { auto reshape_exprs_with_innermost_logical_id = DependencyCheck::getAllExprsBetween( {reshape_out->getRootDomain().begin(), reshape_out->getRootDomain().end()}, {reshape_out->getLogicalDomain().back()}); reshape_exprs_with_innermost_logical_id_set = { reshape_exprs_with_innermost_logical_id.begin(), reshape_exprs_with_innermost_logical_id.end()}; } auto reshape_out_loop_domain = reshape_out->getLoopDomain(); for (auto reshape_exprs_it = reshape_exprs.rbegin(); reshape_exprs_it != reshape_exprs.rend(); ++reshape_exprs_it) { auto reshape_expr = *reshape_exprs_it; if (skip_innermost_id && reshape_exprs_with_innermost_logical_id_set.count(reshape_expr)) { continue; } // If any of the output IDs of reshape_expr is not found in // cancellable_ids, that means the expr cannot be cancelled. if (std::any_of( Test Setup The ResizeTest and ResizeSchedulerTest classes now disable the resize scheduler by default. Verify that these tests are still valid and that disabling the scheduler does not affect the test outcomes. using ResizeTest = NVFuserTest; using ResizeSchedulerTest = NVFuserFixtureParamTest<bool>;

[naoyam]

!test

[naoyam]

!test

[naoyam]

!test