-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[マイページ]購入報告・マイページに必要なAPIの定義 #911
base: develop
Are you sure you want to change the base?
Conversation
file: | ||
type: string | ||
format: binary | ||
description: 購入報告書のファイル、ない場合更新しないようにする | ||
buy_report: | ||
$ref: "#/components/schemas/buyReport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
画像もバックエンドに送って、そこからMIniOにあげるようにしたい感
フロントもシンプルになる
application/json: | ||
schema: | ||
type: object | ||
/buy_reports/list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
購入報告で表示する購入報告の一覧
year指定で年度、何もなしで全件取得
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ名称detailsでも良いのでは
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントしました!
buy_report: | ||
$ref: "#/components/schemas/buyReport" | ||
required: | ||
- file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[imo]
これ画像がない時とか無かったでしたっけ。まだ企業から画像貰えてないとか
だからrequiredにしなくてもよいかも
required: | ||
- file | ||
- buy_report | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中でrequired入れてるしなくてもいいのでは
required: true | ||
responses: | ||
"200": | ||
description: 作成されたbuyReportが返ってくる |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
めちゃ細かいけどここスネークだとdescriptionの統一感ある。
application/json: | ||
schema: | ||
type: object | ||
/buy_reports/list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ名称detailsでも良いのでは
description: マイページで表示する購入報告の情報 | ||
type: object | ||
properties: | ||
ID: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ小文字かも
id
description: 購入報告ページで表示する詳細情報 | ||
type: object | ||
properties: | ||
ID: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここも
resolve #910
概要
マイページと購入報告ページで必要になりそうなAPIを定義しました
/buy_report
/buy_report/{id}
/buy_report/{id}
/buy_report/list
/buy_report/status/{buy_report_id}
/festival_items/details/{division_id}
画面スクリーンショット等
テスト項目
備考