局divisionAPIの作成 #909
Merged
局divisionAPIの作成 #909
+439
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TFes/FinanSu into feat/hikahana/904-create-division-api
…4-create-division-api
Kubosaka
reviewed
Jan 14, 2025
Kubosaka
reviewed
Jan 15, 2025
Kubosaka
requested changes
Jan 16, 2025
| func (d *divisionController) IndexDivisions(c echo.Context) error { | ||
| ctx := c.Request().Context() | ||
| year := c.QueryParam("year") | ||
| financialRecordId := c.QueryParam("financial_record_id") |
There was a problem hiding this comment.
[must]これopenapiとクエリパラメータとどっちか揃えてください！
| ds = ds.Where(goqu.Ex{"years.year": year}) | ||
| } | ||
| if financialRecordId != "" { | ||
| ds = ds.Where(goqu.Ex{"financial_records.idr": financialRecordId}) |
There was a problem hiding this comment.
[must]
ごめん、タイポしてた
Suggested change
| ds = ds.Where(goqu.Ex{"financial_records.idr": financialRecordId}) | |
| ds = ds.Where(goqu.Ex{"financial_records.id": financialRecordId}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #904
概要
divisionsのAPIを作成しました。
getは年度とfinancialRecordIdをパラメータで指定できます。
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考