Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minioのディレクトリ整理&広告データが変更・削除された時minioのオブジェクトも削除 #863

Merged
merged 2 commits into from
Jul 28, 2024
Merged

minioのディレクトリ整理&広告データが変更・削除された時minioのオブジェクトも削除 #863

merged 2 commits into from
Jul 28, 2024

Conversation

Kubosaka
Copy link
Collaborator

@Kubosaka Kubosaka commented Jul 28, 2024 •
edited by hikahana
Loading

resolve #862

概要

  • minioのディレクトリ整理 /finansu/{年度}/advertisements/{filename}に格納される
  • 広告データが変更・削除された時minioのオブジェクトも削除

画面スクリーンショット等

  • URL

スクリーンショット 2024-07-28 14 14 07

テスト項目

  • 新しく登録したデータが正しく表示されるか
  • これまでに登録していたデータを
  • {年度}/advertisements/に移動させて正しく表示されるか
  • 広告データを変更した際に、これまでのデータが削除されているか

備考

@Kubosaka Kubosaka requested review from hikahana and TkymHrt July 28, 2024 05:19
@Kubosaka Kubosaka self-assigned this Jul 28, 2024
hikahana
hikahana approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 9c4f168 into develop Jul 28, 2024
3 checks passed
@Kubosaka Kubosaka deleted the feat/kubosaka/862-organize-advertisement branch July 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikahana hikahana hikahana approved these changes

@TkymHrt TkymHrt Awaiting requested review from TkymHrt

Assignees

@Kubosaka Kubosaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

広告のminioディレクトリ整理と変更時オブジェクト削除
2 participants
@Kubosaka @hikahana