Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

購入申請登録時にSlack通知 #845

Merged
merged 5 commits into from
Jul 16, 2024
Merged

購入申請登録時にSlack通知 #845

merged 5 commits into from
Jul 16, 2024

Conversation

Kubosaka
Copy link
Collaborator

resolve #844

概要

  • "github.com/slack-go/slack"のインストール
  • 通知時に申請、物品、ユーザー、支出、局の情報が必要だったため、Slack通知用のAPIを作成した

画面スクリーンショット等

  • URL
    スクリーンショット 2024-07-12 1 32 22

テスト項目

  • finansu.envにSlackの環境変数を追加
  • 購入申請を登録し、全体Slackの#404_notify_finansu_testチャンネルで通知が来るか確認する

備考

  • いずれは購入申請・物品をまとめて登録するAPIを用意して、その中でSlackの通知も行う

@Kubosaka Kubosaka requested review from hikahana and TkymHrt July 12, 2024 04:27
@Kubosaka Kubosaka self-assigned this Jul 12, 2024
TkymHrt
TkymHrt approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@TkymHrt TkymHrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正常な動作が確認できました！

hikahana
hikahana reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 756c512 into develop Jul 16, 2024
2 checks passed
@Kubosaka Kubosaka deleted the feat/kubosaka/844-notify-slack branch July 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikahana hikahana hikahana left review comments

@TkymHrt TkymHrt TkymHrt approved these changes

Assignees

@Kubosaka Kubosaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

購入申請時にSlack通知
3 participants
@Kubosaka @hikahana @TkymHrt