[fix]編集モーダルでユーザーが反映されないバグ修正 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyusuke3263
requested review from
imaimai17468,
KazumaSun and
Kubosaka
and removed request for
imaimai17468 and
KazumaSun
imaimai17468
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
抽出部分LGTMだと思います
valueに値を入れるか/optionにseletcted属性をつけて選択済みにするかは @Kubosaka の判断に任せます！
Kubosaka
requested changes
Dec 10, 2023
There was a problem hiding this comment.
ブラウザで
Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.
のwarningが出ているので(おそらく前から)、せっかくなんで、初期値はselectタグのvalueで設定しましょうか。
自分のドラフトのPRを参考にやってみてください。
不明な点があれば気軽に聞いてください。
Closed
KazumaSun
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #647
概要
協賛活動の編集モーダル変更がうまく反映されないバグの修正。
画面スクリーンショット等
URLスクリーンショット
テスト項目
-協賛活動の編集モーダルで担当者を変更し、変更が反映されているか確認する
備考