Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 Release #13

Merged
merged 456 commits into from
Jan 16, 2025
Merged

v1.0 Release #13

merged 456 commits into from
Jan 16, 2025

Conversation

aromanielloNTIA
Copy link
Member

  • PropLib 2.0 refactor with cross-platform support
  • Removes .NET wrapper, which is being migrated to its own repository
  • Adds CI workflows to ensure code quality and functionality
  • Adds cross-platform command-line driver to run the model with text file I/O
  • Adds Doxygen for documentation of C++ code, including automated deployment with GitHub Actions and GitHub Pages
  • Code modernization and refactoring

Following this PR, a new v1.0 release will be created.

Note that some links in the README direct to NTIA repositories which are not yet public.

@aromanielloNTIA aromanielloNTIA self-assigned this Jan 13, 2025
@blainNTIA
Copy link

I'm seeing some tests fail. Can you check on these?

 ASMDriverTest.TestSuccess<ASMDriverTest> [TestSuccess]
   Source: TestDriverASM.cpp line 25
   Duration: 1.2 sec

  Message: 
    
    Expected equality of these values:
      asm_rtn
        Which is: 3
      expected_rtn
        Which is: 0

  Stack Trace: 
    TestDriverASM.cpp:18 line 18
 HGTCMDriverTest.TestSuccess<HGTCMDriverTest> [TestSuccess]
   Source: TestDriverHGTCM.cpp line 25
   Duration: 2.6 sec

  Message: 
    
    Expected equality of these values:
      hgtcm_rtn
        Which is: 3
      expected_rtn
        Which is: 0

  Stack Trace: 
    TestDriverHGTCM.cpp:18 line 18

 TSMDriverTest.TestSuccess<TSMDriverTest> [TestSuccess]
   Source: TestDriverTSM.cpp line 25
   Duration: 1.4 sec

  Message: 
    
    Expected equality of these values:
      tsm_rtn
        Which is: 3
      expected_rtn
        Which is: 0

  Stack Trace: 
    TestDriverTSM.cpp:18 line 18
 AeronauticalStatisticalModelTest.TestAeronauticalStatisticalModel<AeronauticalStatisticalModelTest> [TestAeronauticalStatisticalModel]
   Source: TestAeronauticalStatisticalModel.cpp line 22
   Duration: < 1 ms

  Message: 
    
    Expected: (static_cast<int>(testData.size())) != (0), actual: 0 vs 0

  Stack Trace: 
    TestAeronauticalStatisticalModel.cpp:24 line 24
 HeightGainTerminalCorrectionModelTest.TestHeightGainTerminalCorrectionModel<HeightGainTerminalCorrectionModelTest> [TestHeightGainTerminalCorrectionModel]
   Source: TestHeightGainTerminalCorrectionModel.cpp line 25
   Duration: < 1 ms

  Message: 
    
    Expected: (static_cast<int>(testData.size())) != (0), actual: 0 vs 0

  Stack Trace: 
    TestHeightGainTerminalCorrectionModel.cpp:27 line 27
 TerrestrialStatisticalModelTest.TestTerrestrialStatisticalModel<TerrestrialStatisticalModelTest> [TestTerrestrialStatisticalModel]
   Source: TestTerrestrialStatisticalModel.cpp line 21
   Duration: < 1 ms

  Message: 
    
    Expected: (static_cast<int>(testData.size())) != (0), actual: 0 vs 0

  Stack Trace: 
    TestTerrestrialStatisticalModel.cpp:23 line 23

@aromanielloNTIA
Copy link
Member Author

The error described above has been addressed through configuration changes (removal of the /MT configuration with MSVC compiler). Proceeding to merge and create a pre-release to test wrappers.

@aromanielloNTIA aromanielloNTIA merged commit 48c6268 into main Jan 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants