New ResStockArgumentsPostHPXML measure #929
Merged
+283
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess one small drawback is that options_lookup has to change to |
|
You think |
|
Yes, I think the post measure should be more generic since it may modify the HPXML in the future. I suggest ResStockArguments for the pre measure because A) it's not a change and B) some ResStock users may not even know (or care) what HPXML is. |
joseph-robertson
changed the title
…25e1b cdaa4925e1b Merge pull request #1086 from NREL/sleep-schedule 7ef60a444ed Support schedule file debug for run_simulation, and test. 094b1a69e95 Remove a measure error test. fb89c3a431b Regenerate schedule files. c651ae27576 Update new location method. 10f33001530 Remove col names check. 94b06377268 Add optional debug argument. 09b0570661c Add another path check for get_epw_path method. 86fffa11572 Merge branch 'master' into sleep-schedule 9c6a1ec42e7 Merge pull request #1083 from NREL/seasons_improvements cb8b2ba741e Use a common method for getting epw path. 2c0769db710 Merge branch 'master' into sleep-schedule 0f44a841206 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into seasons_improvements 76e3ff5348d Merge pull request #1087 from NREL/timeseries_csv_dview d08989db0d7 Update schedule file resources. 253bfa04924 Sleep unaffected by vacancy. 7e1a2c711ca First pass. c1183a71fd3 Export stochastic sleep schedule. 9ee476ef4cc Merge pull request #1084 from NREL/expand_version 976d48063b5 Add EnergyPlus and OpenStudio versions to the `--version` command. 7175511a572 Latest results. edd732362c4 Fix CI tests. Add workflow test asserts for zero unmet hours when there is no heating/cooling system. d3257820783 Avoid unmet hours from being reported when there's no heating and/or cooling system. 1c2013611b0 Bugfix if run period is a single day. aec298eaaaa Use EMS to avoid unmet hours from being reported outside the heating/cooling seasons. Also allows timeseries unmet hours to be requested. 38f55ef2e18 Latest results. f4d27c50aec Remove ideal air system for seasons implementation. This allows temperatures to properly float (with the small disadvantage that the simulation will now report unmet hours). a2950212935 Merge pull request #1080 from NREL/vent_bugfix 2ce33f78bff Latest results. aede0a82fef Fix possible bug when there are multiple vented crawlspaces/attics defined. e54fbd838b1 Bump to 1.4.0 5c6fb2e4894 Add more files to the release zip. 8d894caafb5 Add ReportUtilityBills measure to release. a84c3343ccf Fix creation of documentation when creating release zips. git-subtree-dir: resources/hpxml-measures git-subtree-split: cdaa4925e1be7f0d1eed7d623d689a5dfe38f2ec
joseph-robertson
commented
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #927. This is the pre-cursor to, e.g, #931 and #1259. In short, we can use generated schedules (e.g., occupant schedule) to create other detailed schedules (e.g., setpoint schedules).
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run