Upload precomputed buildstock.csv for national_baseline and testing_baseline for reproducing issue #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
jmarrec
commented
May 15, 2024
| bundle exec rake workflow:analysis_tests | ||
|
|
||
| - name: Upload precomputed buildstocks | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
Even if it failed, still upload the precomputed buildstocks. So that locally you can just reproduce with the same sampling.
This is helpful only if the sampling is non-deterministic.
Comment on lines
+128
to
+129
| testing_baseline/buildstock.csv | ||
| national_baseline/buildstock.csv |
| name: precomputed_buildstocks | ||
|
|
||
| - name: Upload run_analysis.rb results | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
Always upload whatever results even if failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Patches #1242
View changes without withespace https://github.com/NREL/resstock/pull/1243/files?w=1
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run